Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #6290

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Mar 18, 2024

  • Matches the template for Field Mapping Tasking Manager.
  • Useful for devs to structure PRs and be prompted for relevant info.
  • May require minor refinement in future when we work out how to create a markdown list without Github tracking 'tasks complete':

image

Example from FMTM: hotosm/fmtm#1352

Feel free to update as needed or suggest changes @ramyaragupathy @petya-kangalova

Example PR Title

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Example: Fixes #123

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ramyaragupathy
Copy link
Member

@petya-kangalova - could you please give a first pass for this PR?

Copy link
Collaborator

@petya-kangalova petya-kangalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramyaragupathy I just had a look - this is amazing! All makes sense to me, cannot think of improvement, links to correct TM contributors guidelines as well. I think we should go ahead, approve and see how people use it, then we can iterate and make changes if needed.

@ramyaragupathy ramyaragupathy merged commit a64cbac into hotosm:develop Mar 19, 2024
6 of 7 checks passed
@spwoodcock spwoodcock deleted the docs/pr-template branch March 19, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants