Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: enable ion-spinner on 'Regenerate Shipping Label' Action in Completed Tab & upgrade the @hotwax/app-theme version(#678) #865

Merged

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#678

Short Description and Why It's Useful

  • Instead of using a function that lists the completed orders after cloning the completedOrders getter, which was not showing reactivity when changing the properties of an order, I replaced that function with a variable that maintains a cloned list of completed orders.
  • Additionally, I updated the @hotwax/app-theme version to apply CSS to the ion-spinner inside the ion-button.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 merged commit 17926aa into hotwax:main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants