Skip to content

Commit

Permalink
Merge pull request #593 from amansinghbais/#528-fixes
Browse files Browse the repository at this point in the history
Fixed: count name not updating on UI post successfull api call and duplicate facility coming on infinite scrolling (#528)
  • Loading branch information
ymaheshwari1 authored Jan 9, 2025
2 parents eb35be5 + cc7a502 commit a449183
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"Group": "Group",
"Hard Count": "Hard Count",
"HARD COUNT": "HARD COUNT",
"Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will defaulted to 0 on hand.": "Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will defaulted to 0 on hand.",
"Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will be defaulted to 0 on hand.": "Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will be defaulted to 0 on hand.",
"If a file includes multiple facilities, a count is created for every facility. All items with no facility location will be added to the same count.": "If a file includes multiple facilities, a count is created for every facility. All items with no facility location will be added to the same count.",
"Import CSV": "Import CSV",
"Import Error": "Import Error",
Expand Down
8 changes: 4 additions & 4 deletions src/views/AssignedDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,12 @@ async function updateCountName() {
}
if(countName.value.trim() !== currentCycleCount.value.countName?.trim()) {
const inventoryCountImportId = await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
if(inventoryCountImportId) {
await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
.then(() => {
currentCycleCount.value.countName = countName.value.trim()
} else {
}).catch(() => {
countName.value = currentCycleCount.value.countName.trim()
}
})
}
isCountNameUpdating.value = false
Expand Down
8 changes: 4 additions & 4 deletions src/views/DraftDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,12 @@ async function updateCountName() {
}
if(countName.value.trim() !== currentCycleCount.value.countName.trim()) {
const inventoryCountImportId = await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
if(inventoryCountImportId) {
await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
.then(() => {
currentCycleCount.value.countName = countName.value.trim()
} else {
}).catch(() => {
countName.value = currentCycleCount.value.countName.trim()
}
})
}
isCountNameUpdating.value = false
Expand Down
5 changes: 3 additions & 2 deletions src/views/HardCount.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</ion-button>
</ion-item>
<ion-item lines="none">
<ion-label>{{ translate("Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will defaulted to 0 on hand.") }}</ion-label>
<ion-label>{{ translate("Hard counts are used when conducting large scale full counts at facilities. Products are not added to hard counts before they’re assigned. Facilities will count everything they have in stock. Anything they don’t count will be defaulted to 0 on hand.") }}</ion-label>
</ion-item>


Expand Down Expand Up @@ -238,7 +238,8 @@ async function fetchFacilities(vSize?: any, vIndex?: any) {
facilityTypeId: "VIRTUAL_FACILITY",
facilityTypeId_not: "Y",
parentTypeId: "VIRTUAL_FACILITY",
parentTypeId_not: "Y"
parentTypeId_not: "Y",
orderByField: "facilityName"
} as any;
if(queryString.value.trim()) {
Expand Down
8 changes: 4 additions & 4 deletions src/views/PendingReviewDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -346,12 +346,12 @@ async function updateCountName() {
}
if(countName.value.trim() !== currentCycleCount.value.countName.trim()) {
const inventoryCountImportId = await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
if(inventoryCountImportId) {
await CountService.updateCycleCount({ inventoryCountImportId: currentCycleCount.value.countId, countImportName: countName.value.trim() })
.then(() => {
currentCycleCount.value.countName = countName.value.trim()
} else {
}).catch(() => {
countName.value = currentCycleCount.value.countName.trim()
}
})
}
isCountNameUpdating.value = false
Expand Down

0 comments on commit a449183

Please sign in to comment.