Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: showing accepted or rejected status in the items in the assigned status (#565) #577

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Dec 31, 2024

Related Issues

#565

Short Description and Why It's Useful

  • Showing accepted or rejected label on the items showing the status of the item.
  • Added check to hide the remove from count button from the popover.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2025-01-08 19-03-40

Contribution and Currently Important Rules Acceptance

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Jan 8, 2025

@dt2patel Sir, Please review this. Do we require to the make the status in specific colors?

@dt2patel
Copy link
Contributor

dt2patel commented Jan 8, 2025

I guess rejected label should be red

@amansinghbais
Copy link
Contributor Author

amansinghbais commented Jan 8, 2025

@dt2patel sir,

I have added the custom stying class for giving color to the status, since we are not able to use the inline ionic color property on the "p" tag inside the ion-label.
Could you please verify it.

@ymaheshwari1 ymaheshwari1 merged commit 285fa2f into hotwax:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants