Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Added checks for various cases on the "Learn More" modal(#726) #759

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Jan 9, 2025

Related Issues

#726

Short Description and Why It's Useful

  • If a summary is not present for a job, an empty state will appear on the modal.
  • If sources are not present for any reason, the summary may still be visible on the modal.

Screenshots of Visual Changes before/after (If There Are Any)

image
image
Screenshot from 2025-01-09 19-42-54
Screenshot from 2025-01-09 19-37-33

Contribution and Currently Important Rules Acceptance

…twax#726)

- If a summary is not present for a job, an empty state will appear on the modal.
- If sources are not present for any reason, the summary may still be visible on the modal.
@R-Sourabh R-Sourabh requested a review from ymaheshwari1 January 9, 2025 09:30
src/components/LearnMoreModal.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit ec37509 into hotwax:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants