Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19165: Adds exist_ok=True to trace directory creation call #53

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

cademack
Copy link
Member

@cademack cademack commented Jan 31, 2024

Adding exist_ok=True on the mkdir call that creates the directory for the tracefile.

We believe this may be the cause of some test failures where a race condition exists where multiple processes find the directory does not exist, then one creates the directory before the rest. This means that when the following processes attempt to create the directory, it already existed. Adding this flag should prevent these exceptions.

@cademack cademack requested a review from a team as a code owner January 31, 2024 17:50
@calebwherry calebwherry merged commit c713d87 into main Jan 31, 2024
29 checks passed
@calebwherry calebwherry deleted the 19165-exists-ok branch January 31, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants