22759: Updates react_aggregate to use derivation logic for derived features and adds other logic to improve aggregate details when using time-series data
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbeel
reviewed
Feb 12, 2025
jdbeel
reviewed
Feb 12, 2025
jdbeel
reviewed
Feb 12, 2025
cademack
changed the title
react_aggregate to use derivation logic for derived featuresreact_aggregate to use derivation logic for derived features and adds other logic to improve aggregate details when using time-series data
howsoRes
approved these changes
Feb 14, 2025
howsoRes
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
react_aggregateto predict features using their derivation logic rather than directly interpolating the values of influential cases. For now this will be default behavior and will always apply to features where it can, but it is planned to be parametrizable in the future.Additionally adds the time-series context filtering logic that has been present in residuals to MDA and contributions.