Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22864: FIxes incorrect train numeric warning for booleans #432

Merged
merged 2 commits into from
Feb 15, 2025
Merged

22864: FIxes incorrect train numeric warning for booleans #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5588af
22864: FIxes incorrect train numeric warning for booleans
howsoRes Feb 15, 2025
d9b02fb
ut threshold
howsoRes Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion howso/train.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@
(filter
(lambda (or
;only keep numerical nominals/ordinals and non-nominals that aren't datetimes/edit distance/string ordinals features
(contains_index !numericNominalFeaturesMap (get features (current_value)) )
(= "number" (get !numericNominalFeaturesMap (get features (current_value)) ))
(contains_index !ordinalNumericFeaturesSet (get features (current_value)) )
(and
(not (contains_index !nominalsMap (get features (current_value))) )
Expand Down
4 changes: 2 additions & 2 deletions unit_tests/ut_h_dynamic_deviations.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@

(print "Price MAE with Dynamic Deviations is as expected: ")
(call assert_approximate (assoc
exp 325
exp 400
obs (get dd_agg_stats ["feature_residuals_full" "price"])
thresh 200
thresh 300
))
(call exit_if_failures (assoc msg "MAE with DD is not as expected."))

Expand Down