Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #12

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

darshankabariya
Copy link
Contributor

Summary

Enhances error handling in Negentropy C++ wrapper and Nim bindings for Waku Sync. Replaces boolean-based error reporting with system-generated error messages.

Key Changes

  • Added thread-local lastError string and get_last_error() function in C++.
  • Updated C++ functions to set specific error messages.
  • Enhanced Nim bindings to use a new error reporting mechanism.

@hoytech
Copy link
Owner

hoytech commented Oct 8, 2024

Hi! Did you see my comment here? #9 (comment)

In short, I moved the C language wrapper stuff into a new directory c/ to keep a clean separation between the C++ and the bindings. So, this PR will not merge cleanly (but it's probably just a matter of using the new directory structure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants