Skip to content

Conversation

@TheAssembler1
Copy link
Collaborator

@TheAssembler1 TheAssembler1 commented Sep 16, 2025

Rename all client API collective calls to be suffixed with _coll.

Locally compilation with and without PDC_ENABLE_MPI succeeds. Also the serial and shared tests work as expected locally.

#288

@TheAssembler1 TheAssembler1 self-assigned this Sep 16, 2025
@TheAssembler1 TheAssembler1 requested a review from a team as a code owner September 16, 2025 19:10
@TheAssembler1 TheAssembler1 force-pushed the rename_collective_calls branch from 25da06d to 487e7cf Compare September 16, 2025 19:30
@jeanbez jeanbez changed the title Rename collective calls Draft: Rename collective calls Oct 21, 2025
@jeanbez
Copy link
Member

jeanbez commented Oct 21, 2025

Can we unify if we pass the MPI communicator as well?

@TheAssembler1 TheAssembler1 force-pushed the rename_collective_calls branch from 7c4c09b to 2401eb8 Compare October 21, 2025 20:18
@TheAssembler1
Copy link
Collaborator Author

I added the communicator to the Client API calls. This required some of the tests to change since some of the serial tests were calling collective calls which would previously work on those that did not require the MPI communicator. I've added conditional macros to call the collective/independent version depending on if ENABLE_MPI is set.

@TheAssembler1
Copy link
Collaborator Author

Also, previously, the ENABLE_MPI was set in in the CMakeLists.txt using set. However, this was causing some files to have ENABLE_MPI defined and others would not have it defined. I fixed this by using add_compile_definitions(ENABLE_MPI=1) instead. I'm not sure if this is the correct fix...

@TheAssembler1
Copy link
Collaborator Author

TheAssembler1 commented Oct 21, 2025

Some of the collective private client PDC functions use a global variable PDC_CLIENT_COMM_WORLD_g which is set to the communicator instead of an extra comm parameter. I left those as is and only adjusted the public client API functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants