Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for release v0.12: update dist, spec, and documentation #575

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ofaaland
Copy link
Collaborator

Update the dist, specfile used for rpm, and documentation to specify v0.12 for the release.

@ofaaland ofaaland requested a review from gonsie May 31, 2024 23:54
Copy link
Contributor

@gonsie gonsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that you've fixed up the typography (removing smart quotes and ellipsis), but it looks like it didn't quite work for single quote.

@@ -104,7 +104,7 @@ that each symbolic link refers to.
.B \-P, \-\-no\-dereference
Do not follow symbolic links in source paths. Effectviely allows
symbolic links to be copied when the link target is not valid
or there is not permission to read the link’s target.
or there is not permission to read the link\(aqs target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gonsie are you certain the \(aq is incorrect? See my comments on #591. When I look at this generated man/dcp.1 file with the terminal man utility on oslic, it renders correctly.

@@ -125,7 +130,7 @@ Print the command usage, and the list of options available.
.SH EXPRESSIONS
.sp
An expression is made up of one or more conditions, where each condition specifies a field and a state.
A single condition consists of a field name, an ‘=’ sign, and a state name.
A single condition consists of a field name, an \(aq=\(aq sign, and a state name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\(aq should be '

@@ -288,7 +293,7 @@ CONTENT=COMMON => EXISTS=COMMON@TYPE=COMMON@SIZE=COMMON@CONTENT=COMMON
.sp
A successful check on any other field also implies that EXIST=COMMON.
.sp
When used with the \-o option, one must also specify a file name at the end of the expression, separated with a ‘:’.
When used with the \-o option, one must also specify a file name at the end of the expression, separated with a \(aq:\(aq.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again

@satishskamath
Copy link

Any traction on this? Thanks :)

Update the dist, specfile used for rpm, and documentation to
specify v0.12 for the release.

Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
man pages include updates to the version number as well as new features
and changes related to external factors like github URLs for asset
downloads.

See the release notes for details.

Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
@ofaaland
Copy link
Collaborator Author

I rebased my release-0.12 branch to include the dcp fix merged last week, #586

@ofaaland
Copy link
Collaborator Author

ofaaland commented Oct 23, 2024

@carbonneau1 @gonsie I am thinking of holding off on this a couple of weeks so we can add more tests, and pull those tests in, to improve confidence that we didn't introduce a regression with the commits landed to main branch for this release. If you have thoughts they would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants