Refactor of WCS pixelization operator #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielecoppi
approved these changes
May 13, 2024
keskitalo
approved these changes
May 13, 2024
- Move the application of source centering in the projection to a separate helper function in `pointing_utils.py`. Thanks to @gabrielecoppi for identifying this fix. Optionally use this new function when computing the scan range for autoscaling. - In `PixelsWCS`: - Add a new general class method that computes the WCS parameters. - Add support for SFL projection. - Allow projection traits to be changed in any order and only recompute the WCS if needed when exec() is called. - Default to a single submap, which is the most efficient choice for the common case of data distributed by detector and many observations co-incident on the sky. - In the PixelsWCS unit tests: - Ensure projection and plotting works for every supported projection type with both fixed parameters and autoscaling. - Test mapmaking in both normal mode and with source-centered projections in RA/DEC and Az/El. - In `plot_wcs_maps`: - Set the figure size based on the DPI and the actual size of the image in pixels. - Set the unhit pixels to gray. - Allow specifying the color map, and default to one of the perceptially uniform ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is a superset of #727, and includes a larger reorganization of WCS projection support. One note: the WCS standard does not support Alt-Az / Az-El horizon coordinates. Currently the code uses the RA/DEC CTYPE for that case, but I am open to suggestions if there is some common convention for CTYPE in that case.
Changes in this PR include:
Move the application of source centering in the projection to a separate helper function in
pointing_utils.py. Thanks to @gabrielecoppi for identifying this fix. Optionally use this new function when computing the scan range for autoscaling.In
PixelsWCS:In the PixelsWCS unit tests:
In
plot_wcs_maps:Some examples from unit tests showing projection and plotting defaults (input data was noise):
