Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and features for dealing with realistic data. #777

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

tskisner
Copy link
Member

  • Move HWPSS utility functions into a separate source file

  • Add a new CalibrateDetectors operator which takes a dictionary of factors to apply per observation.

  • Change detector timeconstant deconvolution to use serial rather than batched FFTs by default. This reduces memory footprint in the common case where most parallelism comes from MPI.

  • Add option to AzimuthIntervals to also cut extraneous long intervals

  • Support both PDF and PNG image formats for plots.

  • When demodulating data, also propagate per-detector flags.

  • Fix deadlocks caused by logging barriers in noise estimation.

Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please look over the few comments and decide for yourself if any are actionable.

src/toast/hwp_utils.py Show resolved Hide resolved
src/toast/hwp_utils.py Show resolved Hide resolved
src/toast/ops/demodulation.py Show resolved Hide resolved
src/toast/ops/mapmaker_solve.py Show resolved Hide resolved
src/toast/ops/noise_model.py Outdated Show resolved Hide resolved
src/toast/ops/noise_model.py Outdated Show resolved Hide resolved
* Move HWPSS utility functions into a separate source file

* Add a new CalibrateDetectors operator which takes a dictionary of
  factors to apply per observation.

* Change detector timeconstant deconvolution to use serial rather
  than batched FFTs by default.  This reduces memory footprint in
  the common case where most parallelism comes from MPI.

* Add option to AzimuthIntervals to also cut extraneous long intervals

* Support both PDF and PNG image formats for plots.

* When demodulating data, also propagate per-detector flags.

* Fix deadlocks caused by logging barriers in noise estimation.
@tskisner tskisner merged commit 0cec1fd into toast3 Aug 16, 2024
5 of 6 checks passed
@tskisner tskisner deleted the reduction_fixes branch August 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants