Skip to content

Commit

Permalink
HPCC-32762 prevent Dali shutdown crashes due to late MP notifications
Browse files Browse the repository at this point in the history
The MP events (close notifications) could come in as Dali services
were being deleted, resulting in random assert/crashes during
final shutdown.
Shutdown MP before the final clearup phase of Dali services.

Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
  • Loading branch information
jakesmith committed Oct 3, 2024
1 parent 6569a25 commit f2f5b5c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dali/server/daserver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,12 @@ static void stopServer()
server.stop();
}
closeCoven();
stopLogMsgReceivers(); //MORE: deprecated feature, not used by any new clients, remove once all deployed clients that depend on it are upgraded
stopMPServer();
ForEachItemInRev(j,servers)
{
servers.remove(j); // ensure correct order for destruction
}
stopLogMsgReceivers(); //MORE: deprecated feature, not used by any new clients, remove once all deployed clients that depend on it are upgraded
stopMPServer();
}

bool actionOnAbort()
Expand Down

0 comments on commit f2f5b5c

Please sign in to comment.