-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32688 Add JirabotMerge Github Action #19135
base: candidate-9.2.x
Are you sure you want to change the base?
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32688 Jirabot Action Result: |
Notes on merge script: The script uses the target branch and the git tags to determine the correct fix versions to add to the Jira issue. The logic for this is as follow:
Here is an example run from my fork merging into master. It added 9.10.0 to the Jira issue: https://github.com/jpmcmu/HPCC-Platform/actions/runs/10951362829 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good afaics. I have added the relevant variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I didn't review the python code...
.github/workflows/jirabot-merge.yml
Outdated
python -m pip install --upgrade atlassian-python-api | ||
python -m pip install --upgrade jira | ||
- name: "Checkout" | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be version 4
.github/workflows/jirabot-merge.yml
Outdated
echo "Pull Request URL: ${{ github.event.pull_request.html_url }}" | ||
echo "Comments URL: ${{ github.event.pull_request.comments_url }}" | ||
echo "Branch Name: ${{ github.ref_name }}" | ||
- uses: "actions/setup-python@v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be version 5?
.github/workflows/jirabot-merge.yml
Outdated
print('Unable to find Jira issue name in title') | ||
|
||
print(result) | ||
shell: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Move shell to above the run for consistency with other actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes
@GordonSmith thanks for the review, made those changes |
@jpmcmu please look at the security warning - which does indicate a real vulnerability |
- Added a Github action to update Jira issues upon PR merger Signed-off-by: James McMullan James.McMullan@lexisnexis.com
@ghalliday Addressed the security issue and squashed |
Signed-off-by: James McMullan James.McMullan@lexisnexis.com
Type of change:
Checklist:
Smoketest:
Testing: