Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Undici change broke tests #4114

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: Undici change broke tests #4114

merged 1 commit into from
Sep 18, 2023

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Sep 18, 2023 •
edited
Loading

Fixes #4113

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith
fix: Undici change broke tests
91d4bc6 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 95ba6c6 into hpcc-systems:trunk Sep 18, 2023
5 checks passed
@GordonSmith GordonSmith deleted the GH-4113-UNIDCI_TEST_FAIL branch September 18, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undici causing tests to fail
2 participants
@GordonSmith @jeclrsg