-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C / Docker] 412 websocket #519
Draft
felix-20
wants to merge
119
commits into
development
Choose a base branch
from
412-websocket
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 8652a67 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 18:17:20 2022 +0200 missed `handle_requests` on last commit commit a354f89 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 18:16:15 2022 +0200 implement #356 commit fd54365 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 17:56:35 2022 +0200 docstrings commit 9f43c9d Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 15:07:47 2022 +0200 fix docker test commit b3e6e80 Merge: 6f64f9e 091eee6 Author: felix-20 <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 14:31:39 2022 +0200 Merge branch 'development' into 379-multiple-experiments commit 6f64f9e Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 14:20:47 2022 +0200 clean up docker port commit 8c35e8a Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 11:33:30 2022 +0200 merge development commit 091eee6 Author: Nikkel Mollenhauer <57323886+NikkelM@users.noreply.github.com> Date: Mon Apr 11 10:43:00 2022 +0200 Tests for `config_validation.py` (#404) * Don't get default data (shouldn't be necessary) * Unpack default data * Refactored utils functions to return dicts instead of strings * Adapted to new mock format * Adapted to new mock format * Some first tests * More tests * Fixed testcase-names * Moved file-endings to initial function call * Fixed tests * More asserts * More tests * More tests * More tests * `validate_sub_keys`-tests commit f8bc162 Author: jannikgro <52510222+jannikgro@users.noreply.github.com> Date: Fri Apr 8 13:20:42 2022 +0200 [D] Stable baselines integration (#384) * refactored reinforcement learning agent to accept marketplace * adapted test_exampleprinter.py to marketplace initialization * add market option to accept continuos actions * fixed action space check * initial stable baselines integration * Agent init by env (#390) * introduced self.network in actorcritic_agent * added network_architecture in QLearningAgent * changed actorcritic_agent to network_architecture * set back training_scenario * am_configuration initialize rl-agent via marketplace * added final analyse to stable baselines training * added more stable baselines algorithms * added ppo algorithm * introduced stable_baselines_folder * renamed training to callback * satisfied linter * fixed loading problem * try to make tqdm run in stable_baselines * make tqdm running * reduced pmonitoring episodes in sb training * save model only if significantly better * fixed too long test time bug * moved back to 250 episodes testing * set timeout to 15 minutes * added first batch of fixes to @NikkelM feedback * added type annotations and asserts in stable_baselines_model * added sbtraining to training_scenario * applied comments in am_configuration * solved .dat problem and fixed crashing asserts * reintroduced _end_of_training * removed deprecated if * Moved '.dat' to function call instead of appending within function * Fixed assert * fixed model file ending bug * Add short explanation docstring Co-authored-by: Johann Schulze Tast <35633229+blackjack2693@users.noreply.github.com> * fixed wrong docstring * Fixed tests Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de> Co-authored-by: Johann Schulze Tast <35633229+blackjack2693@users.noreply.github.com> commit 0183876 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Mon Apr 11 11:31:15 2022 +0200 name from `names` for container commit ad70b7c Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Sun Apr 10 16:32:47 2022 +0200 fix #380 commit 8e1314c Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Sun Apr 10 16:05:28 2022 +0200 multiple experiments are supported on the webserver commit 53a4000 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Fri Apr 8 14:36:44 2022 +0200 support for starting multiple container on docker side commit 3c94f43 Author: Judith <39854388+felix-20@users.noreply.github.com> Date: Fri Apr 8 11:46:07 2022 +0200 ability to add `DockerInfo` for multiple container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #412
It introduces a websocket on the API side, that the webserver can connect to. This websocket is a bidirectional connection between the docker side and the webserver and it enables the
docker_manager
to tell the webserver if a container has crashed.