Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-4530 adding bingo #569

Merged
merged 58 commits into from
Jul 26, 2023
Merged

BC-4530 adding bingo #569

merged 58 commits into from
Jul 26, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Jul 12, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

hpi-schul-cloud/nuxt-client#2685
hpi-schul-cloud/antivirus_check_service#39
hpi-schul-cloud/schulcloud-server#4270
hpi-schul-cloud/version-aggregator#9
hpi-schul-cloud/superhero-dashboard#218
hpi-schul-cloud/h5p-staticfiles-server#2
hpi-schul-cloud/schulcloud-calendar#140
hpi-schul-cloud/schulcloud-client#3240

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

mamutmk5
mamutmk5 requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mamutmk5 mamutmk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add the dof_bingo part to the workflows, we must update all other workflows in the other Repos who call the workflows from dof_app_deploy and add there the secret BINGO_REPO_TOKEN

.github/workflows/clean_workflow.yml Show resolved Hide resolved
.github/workflows/clean_workflow.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@Loki-Afro Loki-Afro marked this pull request as ready for review July 25, 2023 14:46
mamutmk5
mamutmk5 requested changes Jul 25, 2023
View reviewed changes
.github/workflows/clean_workflow.yml Outdated Show resolved Hide resolved
.github/workflows/clean_workflow.yml Outdated Show resolved Hide resolved
.github/workflows/clean.yml Outdated Show resolved Hide resolved
@Loki-Afro Loki-Afro enabled auto-merge (squash) July 26, 2023 08:37
@Loki-Afro Loki-Afro disabled auto-merge July 26, 2023 08:51
@Loki-Afro Loki-Afro merged commit fd6660b into main Jul 26, 2023
1 check passed
@Loki-Afro Loki-Afro deleted the bc-4530 branch July 26, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamutmk5 mamutmk5 mamutmk5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loki-Afro @mamutmk5