BC-7985 - Adapt sidebar active selection to rooms changes #3390
Conversation
|
| } | ||
| }, | ||
| { immediate: true } | ||
| ); | ||
|
|
||
| const isRoom = computed(() => roomVariant.value === RoomVariant.ROOM); |
There was a problem hiding this comment.
not sure how I feel about roomVariant and RoomVariant working together here. Can we find a more distinctive naming?
There was a problem hiding this comment.
Sure, we can talk about that. I just wanted to avoid having two boolean flags.
| @@ -0,0 +1 @@ | |||
| <template> </template> | |||
There was a problem hiding this comment.
What's this about? Can this be removed again?
There was a problem hiding this comment.
I added the root route to prevent Vue warnings about missing route for path "". This page is actually never rendered. The is there because we cannot have empty <template> tags.
There was a problem hiding this comment.
lets talk tomorrow about the whole idea for the routing so we can all have a similar understanding with the new approach :)
* implement selective sidebar selection for /rooms/:id * fix sidebar selection for board * move sidebar selection to composable * add/fix tests
Short Description
In order to distinguish between the room details and course room details in the sidebar selection we have to add some specific logic.
Links to Ticket and related Pull-Requests
BC-7985
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging