Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2148 Add aria-label to external tool element #3405

Merged
merged 3 commits into from
Sep 20, 2024
Merged

N21-2148 Add aria-label to external tool element #3405

merged 3 commits into from
Sep 20, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Sep 18, 2024 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap MarvinOehlerkingCap changed the title N21-2148 Ad aria-label to external tool element N21-2148 Add aria-label to external tool element Sep 18, 2024
GordonNicholasCap
GordonNicholasCap requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only small changes needed

src/modules/feature/board-external-tool-element/ExternalToolElement.unit.ts Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElement.unit.ts Outdated Show resolved Hide resolved
src/modules/feature/board-external-tool-element/ExternalToolElement.unit.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

GordonNicholasCap
GordonNicholasCap approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, can be merged

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit a2c47db into main Sep 20, 2024
69 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2148-screen-reader-tool-element branch September 20, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonNicholasCap GordonNicholasCap GordonNicholasCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @GordonNicholasCap