Fix text filter tests

hpi-swa-lab · Jul 10, 2023 · 17735be · 17735be
1 parent 27ea78b
commit 17735be
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/projects/bp-gallery/cypress/e2e/link-pictures-with-texts.cy.ts b/projects/bp-gallery/cypress/e2e/link-pictures-with-texts.cy.ts
@@ -1,14 +1,18 @@
 import { login, logout } from '../utils/login-utils';
 
 const checkTextDisplay = ({ prefix = '', pictureId = '2', textId = '1' } = {}) => {
-  cy.contains('Nur Bilder anzeigen');
+  // wait for page to settle
+  cy.contains('Bilder und Texte anzeigen');
+  // go through each text filter option
+  cy.get('[data-testid="text-filter-select"]').click();
+  cy.contains('Nur Bilder anzeigen').click();
   cy.get(`${prefix} #picture-preview-for-${pictureId}`);
   cy.get(`${prefix} #picture-preview-for-${textId}`).should('not.exist');
-  cy.contains('Nur Bilder anzeigen').click();
+  cy.get('[data-testid="text-filter-select"]').click();
   cy.contains('Bilder und Texte anzeigen').click();
   cy.get(`${prefix} #picture-preview-for-${pictureId}`);
   cy.get(`${prefix} #picture-preview-for-${textId}`);
-  cy.contains('Bilder und Texte anzeigen').click();
+  cy.get('[data-testid="text-filter-select"]').click();
   cy.contains('Nur Texte anzeigen').click();
   cy.get(`${prefix} #picture-preview-for-${pictureId}`).should('not.exist');
   cy.get(`${prefix} #picture-preview-for-${textId}`);

diff --git a/projects/bp-gallery/src/components/common/picture-gallery/TextFilterSelect.tsx b/projects/bp-gallery/src/components/common/picture-gallery/TextFilterSelect.tsx
@@ -22,7 +22,12 @@ export const TextFilterSelect = ({
   );
 
   return (
-    <Select value={value} onChange={onSelectChange} variant='standard'>
+    <Select
+      value={value}
+      onChange={onSelectChange}
+      variant='standard'
+      data-testid='text-filter-select'
+    >
       <MenuItem value={TextFilter.ONLY_PICTURES}>{t('common.textFilter.onlyPictures')}</MenuItem>
       <MenuItem value={TextFilter.PICTURES_AND_TEXTS}>
         {t('common.textFilter.picturesAndTexts')}