Permissions enhancements #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove jwt token from changePasswort response.
rheaSPK
approved these changes
Jul 10, 2023
This is to mitigate a bug/behavior with refetchQueries, where getParameterizedPermissions is refetched when the first mutation comes back, but the refetch triggered by later mutations somehow does not run. Batching the mutations solves this problem, since the refetch can only start after all of the mutations have come back, which they can only do together, since they are a batch (currently, there are never more than 50 mutations run at the same time). It also reduces network load as a side benefit.
This is the second part of the fix for the problem described in the previous commit. Batching alone does not help when BooleanParameters change, since they rely on the correct order of delete and add, so the refetch triggered by the delete overshadows the refetch triggered by the add. Refetching manually solves this problem, since a refetch is only triggered after a logical action is completed. Batching is kept for the network load aspect.
projects/bp-gallery/src/components/views/admin/user/PermissionsView.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/admin/user/UsersView.tsx
Outdated
Show resolved
Hide resolved
rheaSPK
approved these changes
Jul 11, 2023
DavidSchroschk
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.