611 strictly necessary improvements for exhibitions #645
Conversation
…sary-improvements-for-exhibitions
…sary-improvements-for-exhibitions
…sary-improvements-for-exhibitions
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitionViewer.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
| @@ -858,6 +818,10 @@ export const ExhibitionStateManager = ({ | |||
| sections={sections} | |||
| setSections={setSections} | |||
| databaseSaver={databaseSaver} | |||
| titlePicture={titlePicture} | |||
| setTitlePicture={setTitlePicture} | |||
| idealot={idealot} | |||
There was a problem hiding this comment.
unused
| idealot={idealot} |
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
| </div> | ||
| ))} | ||
| </div> | ||
| <Gallery |
There was a problem hiding this comment.
Why did you choose to use a new dependency instead of using a PictureGrid? Gallery seems a little out of place (no rounded corners on the pictures, no hover effects, etc.) and also crops the pictures on the left and right.
There was a problem hiding this comment.
because I can't set the hight of a PictureGrid and they need to be bigger than a usual PictureGrid. Before I just used Pictures with flex but this didn't worked on safari.
projects/bp-gallery/src/components/views/exhibitions/ExhibitionTool.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitionTool.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
projects/bp-gallery/src/components/views/exhibitions/ExhibitonUtils.tsx
Outdated
Show resolved
Hide resolved
| group: 'exhibition', | ||
| isAllowed: checkExhibition('id'), | ||
| document: graphql` | ||
| mutation deleteExhibitionSection($id: ID!) { |
There was a problem hiding this comment.
When this PR is merged, we will have to remember to perform some manual database migration to grant these new permissions (this one and deleteExhibitionPicture) to the relevant users.
|
Overall nice work adding (and removing :D) the requested features :) |
tom95
dismissed
MariusDoe’s stale review
concerns addressed, proceeding to merge on staging
MariusDoe
deleted the
611-strictly-necessary-improvements-for-exhibitions
branch
See #611