Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rh 226 locations english and german title and description #249

Merged

Conversation

philbow61
Copy link
Contributor

solves #226

philipraetsch and others added 3 commits February 4, 2022 16:01
Co-authored-by: rieke <rfrx@users.noreply.github.com>
Co-authored-by: rieke <rfrx@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #249 (4eca06e) into dev (8645e83) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #249      +/-   ##
==========================================
- Coverage   98.75%   98.22%   -0.54%     
==========================================
  Files          36       37       +1     
  Lines         884      900      +16     
==========================================
+ Hits          873      884      +11     
- Misses         11       16       +5     
Impacted Files Coverage Δ
app/controllers/buildings_controller.rb 100.00% <100.00%> (ø)
app/controllers/locations_controller.rb 100.00% <100.00%> (ø)
app/controllers/rooms_controller.rb 100.00% <100.00%> (ø)
app/controllers/search_results_controller.rb 83.33% <100.00%> (-7.46%) ⬇️
app/helpers/search_results_helper.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8645e83...4eca06e. Read the comment docs.

Copy link
Contributor

@BenediktV BenediktV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philbow61 philbow61 merged commit ba92ea6 into dev Feb 17, 2022
@philbow61 philbow61 deleted the feature/RH_226_locations-english-and-german-title-and-description branch February 17, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants