#164 make enrollment key optional (#194)

* #164 make enrollment key optional * fix rubocop errors
hpi-swt2 · Jan 16, 2020 · d337d1d · d337d1d
1 parent 516337c
commit d337d1d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/app/models/lecture.rb b/app/models/lecture.rb
@@ -11,7 +11,7 @@ class Lecture < ApplicationRecord
   validates :end_time, presence: true
 
   validates :name, presence: true, length: { in: 2..40 }
-  validates :enrollment_key, presence: true, length: { in: 3..20 }
+  validates :enrollment_key, length: { in: 3..20, if: :enrollment_key_present? }
   scope :active, -> { where status: "running" }
 
 
@@ -61,4 +61,8 @@ def readonly?
     end
     false
   end
+
+  def enrollment_key_present?
+    enrollment_key.present?
+  end
 end
diff --git a/spec/models/lecture_spec.rb b/spec/models/lecture_spec.rb
@@ -14,8 +14,21 @@
     expect(@lecture).not_to be_valid
   end
 
-  it "is not valid without a enrollment key" do
+  it "is valid without an enrollment key" do
     @lecture.enrollment_key = ""
+    expect(@lecture).to be_valid
+  end
+
+  it "is valid with an enrollment key with 3 characters" do
+    @lecture.enrollment_key = "123"
+    expect(@lecture).to be_valid
+  end
+
+  it "is not valid with an enrollment key with 1 to 2 characters" do
+    @lecture.enrollment_key = "1"
+    expect(@lecture).not_to be_valid
+
+    @lecture.enrollment_key = "12"
     expect(@lecture).not_to be_valid
   end