Skip to content

Don't handle universal links on iOS #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't handle universal links on iOS #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions ios/Classes/SwiftFilePickerWritablePlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,18 +312,19 @@ extension SwiftFilePickerWritablePlugin: FlutterApplicationLifeCycleDelegate {
return _handle(url: url, persistable: false)
}

public func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([Any]) -> Void) -> Bool {
// (handle universal links)
// Get URL components from the incoming user activity
guard userActivity.activityType == NSUserActivityTypeBrowsingWeb,
let incomingURL = userActivity.webpageURL else {
logDebug("Unsupported user activity. \(userActivity)")
return false
}
logDebug("continue userActivity webpageURL: \(incomingURL)")
// TODO: Confirm that persistable should be true here
return _handle(url: incomingURL, persistable: true)
}
// This plugin should NOT handle this kind of link
// public func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([Any]) -> Void) -> Bool {
// // (handle universal links)
// // Get URL components from the incoming user activity
// guard userActivity.activityType == NSUserActivityTypeBrowsingWeb,
// let incomingURL = userActivity.webpageURL else {
// logDebug("Unsupported user activity. \(userActivity)")
// return false
// }
// logDebug("continue userActivity webpageURL: \(incomingURL)")
// // TODO: Confirm that persistable should be true here
// return _handle(url: incomingURL, persistable: true)
// }

private func _handle(url: URL, persistable: Bool) -> Bool {
// if (!url.isFileURL) {
Expand Down