-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/ex 136 add note field to category #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds an optional note field to the Category entity, allowing users to add descriptive notes when creating categories. The implementation spans both frontend and backend with proper database migration.
Changes:
- Added a note field to the Category entity with a maximum length of 500 characters
- Updated database schema with Liquibase migration
- Enhanced the create category dialog to include a textarea for notes
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| backend/exence/src/main/resources/db/changelog/v1.1.0/add-note-to-category.yaml | Liquibase migration adding note column to category table |
| backend/exence/src/main/resources/db/changelog/v1.1.0/changelog-v1.1.0.yaml | Version 1.1.0 changelog entry |
| backend/exence/src/main/resources/db/changelog/db.changelog-master.yaml | Master changelog updated to include v1.1.0 |
| backend/exence/src/main/java/com/exence/finance/common/util/ValidationConstants.java | Added CATEGORY_NOTE_MAX_LENGTH constant (500 characters) |
| backend/exence/src/main/java/com/exence/finance/modules/category/entity/Category.java | Added note field to Category entity |
| backend/exence/src/main/java/com/exence/finance/modules/category/dto/CategoryDTO.java | Added note field to CategoryDTO with validation |
| frontend/Exence/src/app/data-model/modules/category/Category.ts | Added optional note field to Category interface |
| frontend/Exence/src/app/private/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts | Added note form control with 500 character max validation |
| frontend/Exence/src/app/private/transactions-and-categories/create-category-dialog/create-category-dialog.component.html | Added textarea input for category notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
backend/exence/src/main/java/com/exence/finance/modules/category/entity/Category.java
Outdated
Show resolved
Hide resolved
ntamasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maga a feature pacek, csak a fölösleges changeket commit előtt nézd meg majd, gondolom rá van küldve a prettier a ts-re is. Majd megcsinálom később a prettier configot, csak odáig még nem jutottam el 😄 , addig szerintem kapcsold ki ts-ben
...ivate/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts
Outdated
Show resolved
Hide resolved
...ivate/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts
Outdated
Show resolved
Hide resolved
...ivate/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts
Outdated
Show resolved
Hide resolved
backend/exence/src/main/java/com/exence/finance/modules/category/dto/CategoryDTO.java
Show resolved
Hide resolved
...ivate/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts
Outdated
Show resolved
Hide resolved
...ivate/transactions-and-categories/create-category-dialog/create-category-dialog.component.ts
Outdated
Show resolved
Hide resolved
hptrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tökéletes példa a liquibases migráció kezelésre
No description provided.