Skip to content

Conversation

@hptrk
Copy link
Owner

@hptrk hptrk commented Jan 12, 2026

No description provided.

@hptrk hptrk self-assigned this Jan 12, 2026
@hptrk hptrk requested review from ntamasa and tamibalogh January 12, 2026 21:53
@hptrk hptrk added the backend label Jan 12, 2026
@hptrk hptrk added this to the v1.1.0 milestone Jan 12, 2026
@hptrk hptrk requested a review from Copilot January 12, 2026 21:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the transaction filtering mechanism from using JPQL queries with Spring Expression Language to QueryDSL for more maintainable and type-safe dynamic query building.

Changes:

  • Replaced custom JPQL findWithFilter query with QueryDSL predicates
  • Introduced TransactionPredicateBuilder utility class for building dynamic query predicates
  • Moved default sorting configuration from service layer to controller layer via @PageableDefault annotation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TransactionPredicateBuilder.java New utility class that builds QueryDSL predicates from transaction filter criteria
TransactionRepository.java Extended with QuerydslPredicateExecutor interface, removed custom JPQL query method
TransactionServiceImpl.java Simplified filtering logic to use QueryDSL predicates instead of repository's custom query method
TransactionControllerImpl.java Added default sort configuration (date descending) to @PageableDefault annotation
libs.versions.toml Added QueryDSL 5.1.0 version definition and library declarations
build.gradle.kts Added QueryDSL dependencies with Jakarta classifier and annotation processor configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hptrk hptrk requested a review from ntamasa January 13, 2026 22:36
@ntamasa ntamasa merged commit 929dc6e into develop Jan 17, 2026
7 checks passed
@ntamasa ntamasa deleted the feature/EX-235-dynamic-search-queries branch January 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants