Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal sheet enhancements #54

Merged
merged 4 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 69 additions & 3 deletions demo/src/main/kotlin/dev/hrach/navigation/demo/NavHost.kt
Original file line number Diff line number Diff line change
@@ -1,10 +1,23 @@
package dev.hrach.navigation.demo

import androidx.compose.animation.EnterTransition
import androidx.compose.animation.ExitTransition
import androidx.compose.animation.core.FastOutLinearInEasing
import androidx.compose.animation.core.LinearOutSlowInEasing
import androidx.compose.animation.core.tween
import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut
import androidx.compose.animation.slideInHorizontally
import androidx.compose.animation.slideInVertically
import androidx.compose.animation.slideOutHorizontally
import androidx.compose.animation.slideOutVertically
import androidx.compose.foundation.shape.CornerSize
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.MaterialTheme
import androidx.compose.runtime.Composable
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.unit.Density
import androidx.compose.ui.unit.dp
import androidx.navigation.NavHostController
import androidx.navigation.compose.NavHost
Expand All @@ -29,9 +42,14 @@ internal fun NavHost(
modalSheetNavigator: ModalSheetNavigator,
bottomSheetNavigator: BottomSheetNavigator,
) {
val density = LocalDensity.current
NavHost(
navController = navController,
startDestination = Destinations.Home,
enterTransition = { SharedXAxisEnterTransition(density) },
exitTransition = { SharedXAxisExitTransition(density) },
popEnterTransition = { SharedXAxisPopEnterTransition(density) },
popExitTransition = { SharedXAxisPopExitTransition(density) },
) {
composable<Destinations.Home> { Home(navController) }
composable<Destinations.List> { List() }
Expand All @@ -40,14 +58,62 @@ internal fun NavHost(
modalSheet<Destinations.Modal2> { Modal2() }
bottomSheet<Destinations.BottomSheet> { BottomSheet(navController) }
}
ModalSheetHost(modalSheetNavigator, containerColor = MaterialTheme.colorScheme.background)
ModalSheetHost(
modalSheetNavigator = modalSheetNavigator,
containerColor = MaterialTheme.colorScheme.background,
enterTransition = { SharedYAxisEnterTransition(density) },
exitTransition = { SharedYAxisExitTransition(density) },
)
BottomSheetHost(
bottomSheetNavigator,
shape = RoundedCornerShape( // optional, just an example of bottom sheet custom property
navigator = bottomSheetNavigator,
shape = RoundedCornerShape(
// optional, just an example of bottom sheet custom property
topStart = CornerSize(12.dp),
topEnd = CornerSize(12.dp),
bottomStart = CornerSize(0.dp),
bottomEnd = CornerSize(0.dp),
),
)
}

private val SharedXAxisEnterTransition: (Density) -> EnterTransition = { density ->
fadeIn(animationSpec = tween(durationMillis = 210, delayMillis = 90, easing = LinearOutSlowInEasing)) +
slideInHorizontally(animationSpec = tween(durationMillis = 300)) {
with(density) { 30.dp.roundToPx() }
}
}

private val SharedXAxisPopEnterTransition: (Density) -> EnterTransition = { density ->
fadeIn(animationSpec = tween(durationMillis = 210, delayMillis = 90, easing = LinearOutSlowInEasing)) +
slideInHorizontally(animationSpec = tween(durationMillis = 300)) {
with(density) { (-30).dp.roundToPx() }
}
}

private val SharedXAxisExitTransition: (Density) -> ExitTransition = { density ->
fadeOut(animationSpec = tween(durationMillis = 90, easing = FastOutLinearInEasing)) +
slideOutHorizontally(animationSpec = tween(durationMillis = 300)) {
with(density) { (-30).dp.roundToPx() }
}
}

private val SharedXAxisPopExitTransition: (Density) -> ExitTransition = { density ->
fadeOut(animationSpec = tween(durationMillis = 90, easing = FastOutLinearInEasing)) +
slideOutHorizontally(animationSpec = tween(durationMillis = 300)) {
with(density) { 30.dp.roundToPx() }
}
}

private val SharedYAxisEnterTransition: (Density) -> EnterTransition = { density ->
fadeIn(animationSpec = tween(durationMillis = 210, delayMillis = 90, easing = LinearOutSlowInEasing)) +
slideInVertically(animationSpec = tween(durationMillis = 300)) {
with(density) { 30.dp.roundToPx() }
}
}

private val SharedYAxisExitTransition: (Density) -> ExitTransition = { density ->
fadeOut(animationSpec = tween(durationMillis = 210, delayMillis = 90, easing = LinearOutSlowInEasing)) +
slideOutVertically(animationSpec = tween(durationMillis = 300)) {
with(density) { 30.dp.roundToPx() }
}
}
27 changes: 27 additions & 0 deletions demo/src/main/kotlin/dev/hrach/navigation/demo/screens/Modal1.kt
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
package dev.hrach.navigation.demo.screens

import android.annotation.SuppressLint
import androidx.activity.compose.BackHandler
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.systemBars
import androidx.compose.foundation.layout.windowInsetsPadding
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedButton
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableIntStateOf
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.navigation.NavController
import dev.hrach.navigation.demo.Destinations
import dev.hrach.navigation.results.NavigationResultEffect
Expand All @@ -33,15 +41,22 @@ internal fun Modal1(navController: NavController) {
}
Modal1(
navigate = navController::navigate,
close = navController::popBackStack,
bottomSheetResult = bottomSheetResult,
)
}

@Composable
private fun Modal1(
navigate: (Any) -> Unit,
close: () -> Unit,
bottomSheetResult: Int,
) {
var disableBackHandling by rememberSaveable { mutableStateOf(false) }
BackHandler(disableBackHandling) {
// no-op
}

Surface(
color = MaterialTheme.colorScheme.inverseSurface,
) {
Expand All @@ -58,6 +73,18 @@ private fun Modal1(
Text("BottomSheet")
}
Text("BottomSheetResult: $bottomSheetResult")

Spacer(Modifier.height(32.dp))

Row(verticalAlignment = Alignment.CenterVertically) {
Text("Disable back handling")
Switch(disableBackHandling, onCheckedChange = { disableBackHandling = it })
}

Spacer(Modifier.height(32.dp))
OutlinedButton(onClick = close) {
Text("Close")
}
}
}
}
Loading