Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authorization to cookies #597

Merged
merged 4 commits into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions back-end/src/ams/views/applicants.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import requests

from django.db.models.query import QuerySet
from django.http import FileResponse

from rest_framework import status
from rest_framework import pagination
Expand All @@ -20,6 +21,7 @@

from drf_spectacular.views import extend_schema, OpenApiParameter

from common.models.universities import Campus
from conf import settings

from common.constants import MUTATE_ACTIONS
Expand Down Expand Up @@ -231,8 +233,11 @@ def generate_excel_report(
self,
request: Request,
excel_generator: tp.Callable[[QuerySet, QuerySet], Path],
) -> Response:
if "campus" not in request.query_params:
) -> tp.Union[FileResponse, Response]:
if (
"campus" not in request.query_params
or request.query_params["campus"] not in Campus
):
return Response(status=status.HTTP_400_BAD_REQUEST)

students = self.get_queryset()
Expand All @@ -250,23 +255,16 @@ def generate_excel_report(
students.filter(university_info__program__faculty__campus=campus),
milspecialties,
)
with open(path, "rb") as file:
export = file.read()
path.unlink(missing_ok=True)

return Response(
export,
headers={
"Content-Disposition": "attachment; filename=export.xlsx",
},
content_type="application/xlsx",
status=status.HTTP_200_OK,
)
campus_name = dict(Campus.choices)[campus]
response_file_name = f"{campus_name}.xlsx"

file = open(path, "rb")
return FileResponse(file, filename=response_file_name)

def generate_docs(
self,
) -> Response:

applicants = self.get_queryset()
data = [
ApplicantSerializer(instance=applicant).data for applicant in applicants
Expand Down
20 changes: 20 additions & 0 deletions back-end/src/common/middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,26 @@
from django.http import HttpResponse
from rest_framework.response import Response

from urllib.parse import unquote


class BearerTokenMiddleware:
def __init__(self, get_response):
self.get_response = get_response

def __call__(self, request):
# Check if there's no Authorization header but there's an Authorization cookie
if (
not request.META.get("HTTP_AUTHORIZATION")
and "Authorization" in request.COOKIES
):
request.META["HTTP_AUTHORIZATION"] = unquote(
request.COOKIES["Authorization"]
)

response = self.get_response(request)
return response


class LoggingMiddleware:
def __init__(self, get_response):
Expand Down
1 change: 1 addition & 0 deletions back-end/src/conf/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@

MIDDLEWARE = [
"common.middleware.LoggingMiddleware",
"common.middleware.BearerTokenMiddleware",
"corsheaders.middleware.CorsMiddleware",
"django.middleware.security.SecurityMiddleware",
"django.contrib.sessions.middleware.SessionMiddleware",
Expand Down
5 changes: 5 additions & 0 deletions front-end/src/store/modules/user.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ import store, { UserModule } from "@/store";
import { login, getUser } from "@/api/user";

import { getError } from "@/utils/message";

import Cookies from "js-cookie";

import { tokenService } from "../../utils/tokenService";

@Module({ store, name: "user", namespaced: true })
Expand All @@ -36,6 +39,7 @@ class User extends VuexModule {
SET_TOKENS({ access, refresh }) {
this.accessToken = access;
this.refreshToken = refresh;
Cookies.set("Authorization", `Bearer ${access}`);

tokenService.setTokens({ access, refresh });
}
Expand All @@ -44,6 +48,7 @@ class User extends VuexModule {
RESET_TOKENS() {
this.accessToken = "";
this.refreshToken = "";
Cookies.remove("Authorization");

tokenService.clearTokens();
}
Expand Down
Loading