Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 허브 태그 자동 생성 조건을 수정한다. #71

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

hseong3243
Copy link
Owner

작업 내용

  • 허브 태그 자동 생성 조건을 추가하였습니다.
    • 최근 하루 안에 만들어진 태그가 있는 경우 예외를 던집니다.
    • 링크 개수가 5의 배수가 아닌 경우 예외를 던집니다.

관련 이슈

@hseong3243 hseong3243 self-assigned this Apr 9, 2024
@hseong3243 hseong3243 linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Apr 9, 2024

Test Results

157 tests  +17   157 ✅ +17   2s ⏱️ ±0s
 48 suites ± 0     0 💤 ± 0 
 48 files   ± 0     0 ❌ ± 0 

Results for commit 87b59a0. ± Comparison against base commit 80721cf.

This pull request removes 2 and adds 19 tests. Note that renamed tests count towards both.
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ 성공: 링크가 5개 이상인 경우 자동 태그 생성한다.
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ 예외(notMetCondition): 링크가 5개 미만인 경우
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [1] totalLinkSize=0
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [1] totalLinkSize=5
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [1] totalLinkSize=6
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [2] totalLinkSize=1
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [2] totalLinkSize=10
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [2] totalLinkSize=9
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [3] totalLinkSize=11
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [3] totalLinkSize=15
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [3] totalLinkSize=2
com.seong.shoutlink.domain.tag.service.TagServiceTest$AutoCreateTagTest ‑ [4] totalLinkSize=14
…

@hseong3243 hseong3243 merged commit 862c619 into main Apr 9, 2024
2 checks passed
@hseong3243 hseong3243 deleted the fix/#70-fix-create-tag-condition branch April 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: 허브 태그 자동 생성 조건을 수정한다.
1 participant