Added on slide on std::expected #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponce
force-pushed
the
sponce_expected
branch
from
308462f to
e68196b
Compare
talk/morelanguage/morestl.tex
Outdated
| enum class Error {...}; | ||
| std::expected<int, Error> parse(std::string_view in) { | ||
| if (is_valid(in)) return convert_to_int(in); | ||
| return std::expected(Error::...); |
There was a problem hiding this comment.
Suggested change
| return std::expected(Error::...); | |
| return std::unexpected(Error::...); |
For the un-happy path, I think the intention is to use std::unexpected, although I have no experience with std::expected yet :)
This is also shown in the example on cppreference: https://en.cppreference.com/w/cpp/utility/expected
There was a problem hiding this comment.
Damn... I did copy the example, so used unexpected, yesterday and when reading it back today, I thought it was a typo and removed it :-D
fixed !
sponce
force-pushed
the
sponce_expected
branch
from
e68196b to
7a8b46f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.