Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in tables of godbolt and good practice links #496

Merged
merged 2 commits into from
Oct 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion talk/expert/coroutines.tex
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ \subsection{Coroutines}
\begin{frame}[fragile]
\frametitlecpp[20]{Resuming a coroutine}
\scriptsize
\begin{exampleblockGB}{User code}{https://godbolt.org/z/qx46Pa4v3}{Resuming a coroutine}
\begin{exampleblockGB}{User code}{https://godbolt.org/z/qx46Pa4v3}{Coroutine resume}
sponce marked this conversation as resolved.
Show resolved Hide resolved
\begin{cppcode*}{gobble=2}
Task myCoroutine() {
std::cout << "Step 1 of coroutine\n";
Expand Down
4 changes: 2 additions & 2 deletions talk/morelanguage/raii.tex
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@

\begin{frame}[fragile]
\frametitlecpp[11]{Quiz: \texttt{std::shared\_ptr} in use}
\begin{exampleblockGB}{What is the output of this code?}{https://godbolt.org/z/vM35Y6qEW}{\texttt{std::shared\_ptr} quiz}
\begin{exampleblockGB}{What is the output of this code?}{https://godbolt.org/z/vM35Y6qEW}{\texttt{shared\_ptr} quiz}
\small
\begin{cppcode*}{gobble=2}
auto shared = std::make_shared<int>(100);
Expand Down Expand Up @@ -397,7 +397,7 @@

\begin{frame}[fragile]
\frametitlecpp[11]{Quiz: \texttt{shared\_ptr} and \texttt{weak\_ptr} in use}
\begin{exampleblockGB}{What is the output of this code?}{https://godbolt.org}{\texttt{shared\_ptr} vs.\ \texttt{weak\_ptr} quiz}
\begin{exampleblockGB}{What is the output of this code?}{https://godbolt.org}{\texttt{shared/weak\_ptr}}
\small
\begin{cppcode*}{gobble=2}
auto shared = std::make_shared<int>(100);
Expand Down
5 changes: 2 additions & 3 deletions talk/objectorientation/advancedoo.tex
Original file line number Diff line number Diff line change
Expand Up @@ -536,13 +536,12 @@
\item And for rare special cases
\end{itemize}
\end{goodpractice}
\pause
\begin{goodpractice}{Absolutely avoid diamond-shaped inheritance}
\begin{goodpracticeWithShortcut}{Absolutely avoid diamond-shaped inheritance}{NO diamond inheritance}
\begin{itemize}
\item This is a sign that your architecture is not correct
\item In case you are tempted, think twice and change your mind
\end{itemize}
\end{goodpractice}
\end{goodpracticeWithShortcut}
\end{frame}

\begin{frame}[fragile]
Expand Down
2 changes: 1 addition & 1 deletion talk/objectorientation/constructors.tex
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
\item A constructor with a single non-default parameter can be used by the compiler for an implicit conversion.
\end{itemize}
\end{block}
\begin{exampleblockGB}{Example}{https://godbolt.org/z/TvqT185fz}{Unary constructor in action}
\begin{exampleblockGB}{Example}{https://godbolt.org/z/TvqT185fz}{Unary constructor}
\begin{cppcode}
void print(const Vector & v) {
std::cout << "printing v elements...\n";
Expand Down