Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slide on jthreads and simplify goodpractice environment #506

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

hageboeck
Copy link
Contributor

@hageboeck hageboeck commented Jan 17, 2024

Extend the discussion of jthread and stop_token as suggested in #272.

As a drive-by improvement, I refactored the goodpractice environment to take optional arguments. Now, only a single command with an optional argument is necessary to pass a shortened title for the index of good practices:

  \end{cppcode}
-  \begin{goodpracticeWithShortcut}{Don't use C's memory management}{C's memory management}
+  \begin{goodpractice}[C's memory management]{Don't use C's memory management}
    Use \cppinline{std::vector} and friends or smart pointers
-  \end{goodpracticeWithShortcut}
+  \end{goodpractice}
\end{frame}

This stays the same:

\begin{goodpractice}{Memory management}

Fix #272

@hageboeck hageboeck self-assigned this Jan 17, 2024
@sponce sponce merged commit 8ecc523 into hsf-training:master Jan 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add slides on std::jthread
2 participants