Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the smartPointers exercise into 5 problems. #530

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

chavid
Copy link
Contributor

@chavid chavid commented Sep 29, 2024

Splitting the smartPointers exercise into 5 problems, plus various cleanup.

@chavid chavid requested review from sponce and hageboeck September 29, 2024 14:05
Copy link
Contributor

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I have one request (the inline static, because we try to teach this in the course), and the others are more suggestions that came while (re-)reading the code.

exercises/smartPointers/problem1.cpp Outdated Show resolved Hide resolved
exercises/smartPointers/problem1.cpp Outdated Show resolved Hide resolved
exercises/smartPointers/problem1.cpp Outdated Show resolved Hide resolved
exercises/smartPointers/problem3.cpp Outdated Show resolved Hide resolved
exercises/smartPointers/problem3.cpp Outdated Show resolved Hide resolved
exercises/smartPointers/problem3.cpp Outdated Show resolved Hide resolved
chavid and others added 9 commits September 29, 2024 17:30
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
…uspluscourse into split-smart-pointers-exercise
@chavid
Copy link
Contributor Author

chavid commented Sep 30, 2024

This one is ok for you, @sponce ?

@sponce
Copy link
Contributor

sponce commented Sep 30, 2024

Yes, it's all fine. Sorry it take a bit more to review (and we were giving the course this morning)

@sponce sponce merged commit f8f2b38 into hsf-training:master Sep 30, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants