-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting the smartPointers exercise into 5 problems. #530
Splitting the smartPointers exercise into 5 problems. #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I have one request (the inline static
, because we try to teach this in the course), and the others are more suggestions that came while (re-)reading the code.
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
…uspluscourse into split-smart-pointers-exercise
This one is ok for you, @sponce ? |
Yes, it's all fine. Sorry it take a bit more to review (and we were giving the course this morning) |
Splitting the smartPointers exercise into 5 problems, plus various cleanup.