Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and deploy to gh pages #84

Merged
merged 2 commits into from
Apr 29, 2024
Merged

feat: build and deploy to gh pages #84

merged 2 commits into from
Apr 29, 2024

Conversation

ariostas
Copy link
Member

Added a workflow to build and deploy to GitHub Pages. Before we merge this PR, someone with admin rights needs to go to the settings of this repo and set the pages source to GitHub Actions.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for nimble-pothos-1ee962 ready!

Name Link
🔨 Latest commit fbd4c17
🔍 Latest deploy log https://app.netlify.com/sites/nimble-pothos-1ee962/deploys/660183c57934930008be9024
😎 Deploy Preview https://deploy-preview-84--nimble-pothos-1ee962.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariostas
Copy link
Member Author

Also, we need to disable the netlify thing.

@klieret
Copy link
Member

klieret commented Mar 25, 2024

Just let me know and I can disable netlify. Though isn't it useful to have preview builds for the PRs? That's something that github doesn't get you.

@klieret
Copy link
Member

klieret commented Mar 25, 2024

I've given you admin priviledges

@ariostas
Copy link
Member Author

Though isn't it useful to have preview builds for the PRs? That's something that github doesn't get you.

@klieret Yeah, that's true. I guess we could just leave the netlify stuff running if you don't mind keeping it on your account (I don't know if they charge you or anything).

@klieret
Copy link
Member

klieret commented Mar 25, 2024

The netlify is running on free tier, so I don't mind just having that running :)

@klieret
Copy link
Member

klieret commented Mar 25, 2024

Feel free to just merge PRs when you see fit!

@ariostas
Copy link
Member Author

The netlify is running on free tier, so I don't mind just having that running :)

Thank you, @klieret. Jim said there's an AWS thing (paid-for by IRIS-HEP) that's used to generate previews for other IRIS-HEP projects, so I'll talk to him about implementing that. I'll let you know if we end up moving away from netlify.

@ariostas ariostas merged commit 09debbd into main Apr 29, 2024
7 checks passed
@ariostas ariostas deleted the cicd branch May 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants