Create user favorite beer model

beers/admin.py

@@ -97,6 +97,14 @@ class ManufacturerAlternateNameInline(admin.TabularInline):
     model = models.ManufacturerAlternateName
 
 
+class UserFavoriteBeerInline(admin.TabularInline):
+    model = models.UserFavoriteBeer
+    queryset = models.UserFavoriteBeer.objects.select_related(
+        "user",
+        "beer__manufacturer",
+    )
+
+
 class ManufacturerAdmin(admin.ModelAdmin):
     def url_fields_set(self, manufacturer):
         fields = [i.name for i in manufacturer._meta.fields if i.name.endswith("_url")]

beers/migrations/0030_userfavoritebeer.py

@@ -0,0 +1,50 @@
+# Generated by Django 2.2.1 on 2019-05-19 13:34
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
+        ("beers", "0029_merge_20190519_1259"),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name="UserFavoriteBeer",
+            fields=[
+                (
+                    "id",
+                    models.AutoField(
+                        auto_created=True,
+                        primary_key=True,
+                        serialize=False,
+                        verbose_name="ID",
+                    ),
+                ),
+                ("notifications_enabled", models.BooleanField(default=False)),
+                (
+                    "beer",
+                    models.ForeignKey(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="favored_by_users",
+                        to="beers.Beer",
+                    ),
+                ),
+                (
+                    "user",
+                    models.ForeignKey(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name="favorite_beers",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
+            ],
+            options={
+                "unique_together": {("beer", "user")},
+            },
+        ),
+    ]

beers/migrations/0032_merge_20191115_0316.py

@@ -0,0 +1,13 @@
+# Generated by Django 2.2.7 on 2019-11-15 03:16
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("beers", "0030_userfavoritebeer"),
+        ("beers", "0031_beer_tweeted_about"),
+    ]
+
+    operations = []

beers/migrations/0035_merge_20200623_1127.py

@@ -0,0 +1,13 @@
+# Generated by Django 3.0.7 on 2020-06-23 11:27
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("beers", "0034_auto_20200602_2202"),
+        ("beers", "0032_merge_20191115_0316"),
+    ]
+
+    operations = []

beers/migrations/0037_merge_20201120_1718.py

@@ -0,0 +1,13 @@
+# Generated by Django 3.1.2 on 2020-11-20 17:18
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("beers", "0035_merge_20200623_1127"),
+        ("beers", "0036_auto_20201112_1705"),
+    ]
+
+    operations = []

beers/migrations/0038_merge_20210220_1507.py

@@ -0,0 +1,13 @@
+# Generated by Django 3.1.7 on 2021-02-20 15:07
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("beers", "0037_merge_20201114_1252"),
+        ("beers", "0037_merge_20201120_1718"),
+    ]
+
+    operations = []

beers/models.py

@@ -1,13 +1,14 @@
 import logging
 
+from django.conf import settings
 from django.contrib.postgres.fields import CITextField
 from django.db import models, transaction
+from django.db.models import JSONField
 from django.db.utils import IntegrityError
 from django.utils.timezone import now
 
 from taps.models import Tap
 from .utils import render_srm
-from django.db.models import JSONField
 
 LOG = logging.getLogger(__name__)
 
@@ -448,3 +449,20 @@ class UntappdMetadata(models.Model):
         models.CASCADE,
         related_name="untappd_metadata",
     )
+
+
+class UserFavoriteBeer(models.Model):
+    user = models.ForeignKey(
+        settings.AUTH_USER_MODEL,
+        models.CASCADE,
+        related_name="favorite_beers",
+    )
+    beer = models.ForeignKey(
+        Beer,
+        models.CASCADE,
+        related_name="favored_by_users",
+    )
+    notifications_enabled = models.BooleanField(default=False)
+
+    class Meta:
+        unique_together = (("beer", "user"),)

beers/serializers.py

@@ -142,3 +142,16 @@ class OtherPKSerializer(serializers.Serializer):
 
     # we'll take care of validating during the view
     id = serializers.IntegerField(min_value=0)
+
+
+class UserFavoriteBeerSerializer(serializers.ModelSerializer):
+    class Meta:
+        model = models.UserFavoriteBeer
+        fields = "__all__"
+        validators = [
+            UniqueTogetherValidator(
+                fields=["user", "beer"],
+                queryset=models.UserFavoriteBeer.objects.all(),
+                message="User is already subscribed to this beer",
+            ),
+        ]

hsv_dot_beer/urls.py

@@ -20,13 +20,12 @@
     undo_clear,
 )
 from venues.views import venue_table
-from .users.views import UserViewSet, UserCreateViewSet
+from .users.views import UserViewSet
 from .views import home
 
 
 router = DefaultRouter()
 router.register(r"users", UserViewSet)
-router.register(r"users", UserCreateViewSet)
 
 urlpatterns = [
     path("accounts/", include("django.contrib.auth.urls")),

hsv_dot_beer/users/admin.py

@@ -1,8 +1,10 @@
 from django.contrib import admin
 from django.contrib.auth.admin import UserAdmin
+
+from beers.admin import UserFavoriteBeerInline
 from .models import User
 
 
 @admin.register(User)
 class UserAdmin(UserAdmin):
-    pass
+    inlines = [UserFavoriteBeerInline]

hsv_dot_beer/users/permissions.py

@@ -1,14 +1,26 @@
 from rest_framework import permissions
 
 
-class IsUserOrReadOnly(permissions.BasePermission):
+class UserPermission(permissions.BasePermission):
     """
-    Object-level permission to only allow owners of an object to edit it.
+    Permissions for the user model:
+
+    1. Admins can do everything
+    2. Normal users can only read/write themselves
     """
 
+    def has_permission(self, request, view):
+        if request.user.is_staff:
+            return True
+        if request.method == "POST" and "subscribe" in request.path:
+            return True
+        return request.method in permissions.SAFE_METHODS + ("PUT", "PATCH")
+
     def has_object_permission(self, request, view, obj):
 
-        if request.method in permissions.SAFE_METHODS:
+        if request.user == obj:
+            return True
+        if request.user.is_staff:
             return True
 
-        return obj == request.user
+        return request.method in permissions.SAFE_METHODS

hsv_dot_beer/users/test/test_views.py

@@ -7,6 +7,9 @@
 from rest_framework.test import APITestCase
 from rest_framework import status
 from faker import Faker
+
+from beers.test.factories import BeerFactory
+from beers.models import UserFavoriteBeer
 from ..models import User
 from .factories import UserFactory
 
@@ -44,6 +47,7 @@ def test_post_request_with_valid_data_succeeds(self):
         ok_(check_password(self.user_data.get("password"), user.password))
 
     def test_post_request_unauthorized(self):
+        self.client.credentials(HTTP_AUTHORIZATION="")
         response = self.client.post(
             self.url,
             json.dumps(self.user_data),
@@ -63,14 +67,79 @@ def setUp(self):
         self.client.credentials(HTTP_AUTHORIZATION=f"Token {self.user.auth_token}")
 
     def test_get_request_returns_a_given_user(self):
+
         response = self.client.get(self.url)
         eq_(response.status_code, status.HTTP_200_OK)
 
     def test_put_request_updates_a_user(self):
+        self.client.credentials(
+            HTTP_AUTHORIZATION=f"Token {self.user.auth_token}",
+        )
+
         new_first_name = fake.first_name()
         payload = {"first_name": new_first_name}
         response = self.client.put(self.url, payload)
         eq_(response.status_code, status.HTTP_200_OK)
 
         user = User.objects.get(pk=self.user.id)
         eq_(user.first_name, new_first_name)
+
+    def test_subscribe_to_beer(self):
+        beer = BeerFactory()
+        url = reverse("user-subscribetobeer", kwargs={"pk": self.user.pk})
+        print(url)
+        payload = {
+            "beer": beer.id,
+            "notifications_enabled": True,
+        }
+        self.client.credentials(
+            HTTP_AUTHORIZATION=f"Token {self.user.auth_token}",
+        )
+
+        response = self.client.post(url, payload)
+        eq_(response.status_code, status.HTTP_200_OK, response.data)
+        eq_(UserFavoriteBeer.objects.count(), 1)
+
+    def test_update_subscription_to_beer(self):
+        beer = BeerFactory()
+        sub = UserFavoriteBeer.objects.create(
+            beer=beer,
+            user=self.user,
+            notifications_enabled=True,
+        )
+        url = reverse("user-subscribetobeer", kwargs={"pk": self.user.pk})
+
+        payload = {
+            "beer": beer.id,
+            "notifications_enabled": False,
+        }
+        self.client.credentials(
+            HTTP_AUTHORIZATION=f"Token {self.user.auth_token}",
+        )
+
+        response = self.client.post(url, payload)
+        eq_(response.status_code, status.HTTP_200_OK, response.content)
+        eq_(UserFavoriteBeer.objects.count(), 1)
+        sub.refresh_from_db()
+        self.assertFalse(sub.notifications_enabled)
+
+    def test_unsubscribe_from_beer(self):
+        beer = BeerFactory()
+        UserFavoriteBeer.objects.create(
+            beer=beer,
+            user=self.user,
+            notifications_enabled=True,
+        )
+        url = reverse("user-unsubscribefrombeer", kwargs={"pk": self.user.pk})
+
+        payload = {
+            "beer": beer.id,
+            "notifications_enabled": False,
+        }
+        self.client.credentials(
+            HTTP_AUTHORIZATION=f"Token {self.user.auth_token}",
+        )
+
+        response = self.client.post(url, payload)
+        eq_(response.status_code, status.HTTP_204_NO_CONTENT, response.content)
+        eq_(UserFavoriteBeer.objects.count(), 0)