Skip to content

fs2-data-xml streaming parser #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

fs2-data-xml streaming parser #25

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1ca64f2
First try at fs2-data parser
armanbilge Jun 10, 2022
2e2935b
Embrace 0.24 bump
armanbilge Jun 11, 2022
32e569e
Decode documents instead of elements
armanbilge Jun 11, 2022
f92af16
Cross-build for Scala.js
armanbilge Jun 11, 2022
62bfde3
Fix docs
armanbilge Jun 11, 2022
d2426eb
Formatting
armanbilge Jun 11, 2022
72b7b60
Factor out an xml event stream decoder
armanbilge Jun 11, 2022
96e38de
Bikeshed
armanbilge Jun 11, 2022
be9d87f
Merge branch 'series/0.24' into feature/fs2-data-xml-streaming
armanbilge Jun 16, 2022
208fd19
Include comments in event decoder
armanbilge Jun 16, 2022
ceb7dcd
Make `includeComments` configurable
armanbilge Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scala-xml/src/main/scala/org/http4s/scalaxml/ElemInstances.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ trait ElemInstances {
implicit def xmlEvents[F[_]](implicit F: Concurrent[F]): EntityDecoder[F, Stream[F, XmlEvent]] =
EntityDecoder.decodeBy(MediaType.text.xml, MediaType.text.html, MediaType.application.xml) {
msg =>
DecodeResult.successT(msg.bodyText.through(fs2.data.xml.events()))
DecodeResult.successT(msg.bodyText.through(fs2.data.xml.events(includeComments = true)))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to make the new round-trip test pass. But is it actually what we want?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I conflated normalization in the generator with normalization in the test in a way I probably shouldn't have. I guess the question is whether comments are part of normalized output. I think it belongs, perhaps with an option to turn it off.

}

/** Handles a message body as XML.
Expand Down