fix(download): respect Content-Length when Content-Encoding is present#1652
Closed
ali90h wants to merge 2 commits intohttpie:masterfrom
ali90h:feature/fix-content-length-handling-in-download
Closed
fix(download): respect Content-Length when Content-Encoding is present#1652ali90h wants to merge 2 commits intohttpie:masterfrom ali90h:feature/fix-content-length-handling-in-download
ali90h wants to merge 2 commits intohttpie:masterfrom
ali90h:feature/fix-content-length-handling-in-download
Conversation
Per RFC 9110 § 8.6 the Content-Length header reflects the **encoded** size. The previous logic compared it to the decoded size, yielding false "Incomplete download" errors for gzip responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 9110 § 8.6 the Content-Length header reflects the encoded size. The previous logic compared it to the decoded size, yielding false "Incomplete download" errors for gzip responses.