Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2 - Added more texts and pages (new attempt) #380

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

gerritbehrens
Copy link
Contributor

Opening a Pull Request to Update your Project

I've started a documentation on how we should use the forking workflow here:

https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md
(will not be merged to main due to file sizes)

Please follow these Steps & Guidelines for your Pull Request:

Before you Request a Review Check and Tick these Boxes:

[x] make sure that the hugo site build works and check the result visually.
[x] merge your local branch with upstream/main (see update doc)
[x] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[x] make sure that your PR contains only files / file changes within your project subdirectory.
[x] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[x] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[x] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes:
    https://gerritbehrens.github.io/showtime-website/ss24/master/m2-food4future/

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR):
    He did not react to my email since Wednesday.

  4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:

IMPORTANT: if you run into trouble / If the checks fail...

  • if you cannot figure out why a check fails or you think that it may be wrong,
    don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)

  • run the checks locally with:

    ./bin/check-project-update-pr/run-all.sh <project_id>

All good?

If all checks run successfully the PR will be reviewed and, if no
further changes are requested, merged and closed.
(this is the time to update and start a new branch!)

More Information

We are using the Forking Workflow.

@gerritbehrens
Copy link
Contributor Author

Ich habe das Projekt neu geforkt und meine Änderungen an den Texten erneut hinzugefügt. Ich hoffe, dass jetzt alles passt. Die CI sieht ja schonmal gut aus.

Copy link
Contributor

@bkleinen bkleinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte story.md nochmal prüfen, und dann entweder noch ändern oder kommentieren ob Sie es so lassen wollen, dann merge ich den PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vielleicht noch als draft oder zumindest ein "Will be continued...." drunter? Oder soll das so kurz bleiben?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das soll gern so bleiben. Ich könnte mir höchstens noch Illustrationen des "No-Land"-Szenarios vorstellen, aber das werde ich ggf. in der letzten Iteration einfügen. Vielen Dank für den Hinweis.

@gerritbehrens
Copy link
Contributor Author

Der PR darf gern so bleiben. Vielen Dank für den Hinweis.

@bkleinen bkleinen merged commit cfc6c8c into htw-imi-showtime:main Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants