M2 - Added more texts and pages (new attempt) #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a Pull Request to Update your Project
I've started a documentation on how we should use the forking workflow here:
https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md
(will not be merged to main due to file sizes)
Please follow these Steps & Guidelines for your Pull Request:
Before you Request a Review Check and Tick these Boxes:
[x] make sure that the hugo site build works and check the result visually.
[x] merge your local branch with upstream/main (see update doc)
[x] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[x] make sure that your PR contains only files / file changes within your project subdirectory.
[x] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[x] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[x] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh
Note that if you fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY
[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)
Fill out this Information:
Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:
URL of your Preview Site Containing the Changes:
https://gerritbehrens.github.io/showtime-website/ss24/master/m2-food4future/
When did your Project Supervisor review your changes? (Date/Note or require review for PR):
He did not react to my email since Wednesday.
If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:
IMPORTANT: if you run into trouble / If the checks fail...
if you cannot figure out why a check fails or you think that it may be wrong,
don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)
run the checks locally with:
./bin/check-project-update-pr/run-all.sh <project_id>
All good?
If all checks run successfully the PR will be reviewed and, if no
further changes are requested, merged and closed.
(this is the time to update and start a new branch!)
More Information
We are using the Forking Workflow.