Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2: Change: fixed missing section tag & cleaned up structure #387

Merged
merged 10 commits into from
Jul 20, 2024

Conversation

Nemozi
Copy link
Contributor

@Nemozi Nemozi commented Jul 17, 2024

…ontent from features, content & techstack

Opening a Pull Request to Update your Project

I've started a documentation on how we should use the forking workflow here:

https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md
(will not be merged to main due to file sizes)

Please follow these Steps & Guidelines for your Pull Request:

Before you Request a Review Check and Tick these Boxes:

[] make sure that the hugo site build works and check the result visually.
[] merge your local branch with upstream/main (see update doc)
[] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[] make sure that your PR contains only files / file changes within your project subdirectory.
[] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes:

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR):

  4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:

IMPORTANT: if you run into trouble / If the checks fail...

  • if you cannot figure out why a check fails or you think that it may be wrong,
    don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)

  • run the checks locally with:

    ./bin/check-project-update-pr/run-all.sh <project_id>

All good?

If all checks run successfully the PR will be reviewed and, if no
further changes are requested, merged and closed.
(this is the time to update and start a new branch!)

More Information

We are using the Forking Workflow.

Copy link
Contributor

@bkleinen bkleinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe das Gefühl, dass die Projektbeschreibung mit jeder Überarbeitung weiter von dem weg rückt, was mein Verständnis/die Ursprüngliche Idee des Proktes war, uns Sie es als Ihre eigene Idee darstellen:
"Makesign is a digital signage project aimed at motivating students to promote their projects while also learning more about the university's offerings." ????

und:
-subtitle = "Digital Signage für den IDiA-Makerspace"
+subtitle = "Digital Signage for the Campus"

? - darüber haben wir nie gesprochen, ich habe es allenfalls als mögliche Erweiterung genannt. Ausgangspunkt ist aber das Buchungssystem und der Makerspace.

@Nemozi
Copy link
Contributor Author

Nemozi commented Jul 18, 2024

Okay, der Text ist jetzt nochmal mehr überarbeitet und bezieht sich wieder stärker auf die Einbindung mit IDiA. Wir hatten den Text so generell gestaltet, um die zukünftigen Möglichkeiten der Erweiterung als Digital Signage für den ganzen Campus zu betonen. Ich wollten es möglichst generell halten. Es sollte jetzt nicht so rüberkommen, als wäre das unsere eigene Idee gewesen. Das tut mir leid. Ich hoffe, jetzt ist es klarer.

Copy link
Contributor

@bkleinen bkleinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtitle = "Digital Signage für den IDiA-Makerspace"
subtitle = "Digital Signage for the IDEA Makerspace"

htw does not discard functioning monitors. Better: re-purpose old hardware or something

nemo added 7 commits July 20, 2024 16:23
	new file:   content/ss24/bachelor/b2-makesign/Hyun.png
	new file:   content/ss24/bachelor/b2-makesign/Nemo.png
	new file:   content/ss24/bachelor/b2-makesign/Nikki.png
	new file:   content/ss24/bachelor/b2-makesign/rudi.png
	deleted:    Airon.png
	new file:   Hyun.jpg
	deleted:    Hyun.png
	new file:   Nemo.jpg
	deleted:    Nemo.png
	new file:   Nikki.jpg
	deleted:    Nikki.png
	new file:   Rudi.jpg
	deleted:    rudi.png
@Nemozi
Copy link
Contributor Author

Nemozi commented Jul 20, 2024

Okay, peinlich der Rechtschreibfehler, hab ich ausversehen uebersehen. Wir haben das Phrasing und die Rechtschreibung angepasst. Die Bilder sind jetzt auch komprimiert und hochgeladen.

@bkleinen bkleinen merged commit 8933937 into htw-imi-showtime:main Jul 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants