forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-51022][SQL] Remove unused
tableSampleClause
in build()
met…
…hod of `MsSqlServerSQLQueryBuilder` and `DB2SQLQueryBuilder` ### What changes were proposed in this pull request? This PR aims to remove unused `tableSampleClause` in `build()` method of `MsSqlServerSQLQueryBuilder` and `DB2SQLBuilder`. From the discussion here: apache#49711 (comment) ### Why are the changes needed? Currently, `MsSqlServerDialect` and `DB2Dialect` don't support `tableSample` (default value of `supportsTableSample` is `false`), so `tableSampleClause` is unnecessary when building sql in the `build()` method. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated a related test case and passed GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49714 from wayneguow/jdbc_tablesample. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: beliefer <beliefer@163.com>
- Loading branch information
Showing
4 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters