-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split pull request search from issue; extend with filters #1693
Split pull request search from issue; extend with filters #1693
Conversation
Did you commit and push any updates? I just did so. |
src/main/java/org/kohsuke/github/GHPullRequestSearchBuilder.java
Outdated
Show resolved
Hide resolved
Sorry my bad - didn't notice those changes in javadoc |
src/main/java/org/kohsuke/github/GHPullRequestSearchBuilder.java
Outdated
Show resolved
Hide resolved
@kgromov |
I'll take a look. |
Snapshots can be taken from anywhere, but we prefer the test org for later rerecording if needed. It shouldn't cause failures though. |
Again, you need to check in files created during |
…estPullRequestsSearch
@bitwiseman can you please trigger build - I've updated snapshots few days ago |
And again please (hopefully last time) - I missed one obvious part that wasn't specified in the CONTRIBUTING.md 😊 |
Please update the contributing doc with the instructions that were missing. Thanks! |
Done (with test data fix) |
Hi, @bitwiseman.
Is it fine or should I cover all methods for new class? |
I'll take a look shortly. |
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
@bitwiseman, can you trigger builds? I guess last commit was fine (I extended code coverage to 91%) - I just forgot, that java.version is 8 |
Hi, @bitwiseman. Any news when PR can be merged, thanks? |
src/main/java/org/kohsuke/github/GHPullRequestSearchBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the test coverage!
This is very close. Last couple questions.
Updated - please take a look last commit |
UPD: rolled back changed type for terms. I would personally make it LinkedHashSe to guarantee terms uniqueness (hopefully it's not affected github API but can add some ambiguity for wirewock mappings):
|
That seems like a reasonable change, but maybe make that in a separate PR after we land this one? |
src/main/java/org/kohsuke/github/GHPullRequestSearchBuilder.java
Outdated
Show resolved
Hide resolved
yes, since it's related to all search builders |
Enhancement
GHPullRequestSearchBuilder
GHRepository#searchPullRequests(GHPullRequestSearchBuilder search)
andGitHub#searchPullRequests
accordingly.Inspiration for this extension was own project with custom filters grouped differently to what github UI prvides (and a bit more user intuitive). And as it turned out library did not have a lot of search parameters in order to shorten search and response time (like created/merged dates and ranges, labels etc).