Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation support #482

Open
kburke opened this issue May 12, 2023 · 1 comment
Open

Refactor validation support #482

kburke opened this issue May 12, 2023 · 1 comment
Labels
P Pitt dev team

Comments

@kburke
Copy link
Contributor

kburke commented May 12, 2023

The entity-api app.py contains methods which could also be helpful to schema_validators.py, such as query_target_entity(), and the code in app.py is fully integrated with caching. Refactor this to a utility module available throughout entity-api.

Also, there are "additional validations" done by entity type rather than in schema_validators.py, possibly due to the need for supporting methods described in the preceding paragraph. Migrate these to schema_validators.py, as appropriate.

@kburke kburke added the P Pitt dev team label May 12, 2023
@shirey shirey added this to Pitt HIVE Jun 7, 2024
@shirey shirey moved this to Backlog in Pitt HIVE Jun 7, 2024
@yuanzhou
Copy link
Member

@kburke it seems this upcoming improvement falls under this category. We can use a schema validator rather than having the validations in app.py. A small step towards this goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P Pitt dev team
Projects
Status: Backlog
Development

No branches or pull requests

2 participants