Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(applicationset): add the ability to exclude files when using the git file generator #13690 #1

Closed
wants to merge 2 commits into from
Closed

feat(applicationset): add the ability to exclude files when using the git file generator #13690 #1

wants to merge 2 commits into from

Conversation

hubmat00
Copy link
Owner

@hubmat00 hubmat00 commented Oct 14, 2023 •
edited
Loading

This PR implements the feature/enhancement for ApplicationSets to exclude specific files or files within specific directories when using the git file generator.

Closes argoproj#13690

The implementation is based on the already existing and proposed PR of @adamjohnson01 in the old repo. Thanks to @adamjohnson01

Note

The include/exclude (filtering) logic of this implementation includes backward-compatibility to already existing ApplicationSets.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@hubmat00 hubmat00 changed the title Feat/add git file exclude feat(applicationset): add the ability to exclude files when using the git file generator Oct 16, 2023
@hubmat00 hubmat00 changed the title feat(applicationset): add the ability to exclude files when using the git file generator feat(applicationset): add the ability to exclude files when using the git file generator #13690 Oct 16, 2023
@hubmat00
feat: add the ability to exclude files when using the git file genera…
6794ea1 
…tor (argoproj#13690)

Signed-off-by: hubmat00 <54903550+hubmat00@users.noreply.github.com>
@hubmat00
feat: filtering logic for exluded paths (git file generator) must sta…
d637488 
…y backwards-compatible with the default greedy git file generator gloobing (argoproj#13690)

Signed-off-by: hubmat00 <54903550+hubmat00@users.noreply.github.com>
@hubmat00 hubmat00 force-pushed the feat/add-git-file-exclude branch from fd4263a to d637488 Compare October 16, 2023 10:42
@hubmat00 hubmat00 closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to exclude files when using the git file generator #468
1 participant
@hubmat00