Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(messageBox): finish messagebox component #525

Closed
wants to merge 19 commits into from

Conversation

JerryWu1234
Copy link
Contributor

请提交 PR 之前确认一下已通过

  1. 看过这个贡献者说明 中文
  2. 测试通过
  3. 如果有相关的 issue,记得关联上
    refactor messagebox components #479

@zqy1151215064
Copy link

zqy1151215064 commented Dec 27, 2020

需要修改的几点
1、组件未移到src/component目录下,且props,只有一个组件时,不需要多添加一个目录单独存放prop.js文件,导出命名为props就行,(单独一个组件时)具体可参考notification的目录结构
2、Vue3 解决了Vue2 mixins这个痛点,应该避免使用mixins,请换一种写法,实现mixins的功能
3、测试不全

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 54.21 32.36 48.96 56.25
packages/input 51.47 29.7 54.9 52.04
Input.vue 87.88 50 77.78 87.88 229-232
calcTextareaHeight.js 5.26 0 0 5.26 32-102
index.js 0 0 0 0
use.js 55.64 37.18 53.85 56.8 ...5,134,183,187,191,202-205,210-211,217-227,231-232,236,240-242,246-248,253-256,260-261,270-289,328
packages/message-box/src 81.16 52.63 84.62 81.75
MessageBox.js 86.67 56.67 100 86.67 18-24,74-80,86-87
MessageBox.vue 76.92 50 73.33 77.92 169,179-180,184-186,199-202,225-227,230-232,249-250

4、MessageBox.js 去掉默认导出方式

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants