Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable find_executable_batch_size on XPU #3236

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Nov 11, 2024

What does this PR do?

Currently, the find_executable_batch_size only works on CUDA and CPU. This PR adds the XPU support for this.

@muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@faaany
Copy link
Contributor Author

faaany commented Nov 19, 2024

Thanks for the correction! @BenjaminBossan

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

The failing test is unrelated, the same test is failing on other PRs.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit cf169a1 into huggingface:main Nov 19, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants