Fix: Exclude module handling in LoRA weight loading#11911
Closed
yeonjoon-jung01 wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix: Exclude module handling in LoRA weight loading#11911yeonjoon-jung01 wants to merge 1 commit intohuggingface:mainfrom
yeonjoon-jung01 wants to merge 1 commit intohuggingface:mainfrom
Conversation
- Updated the logic in to use a set for exclude modules, improving efficiency and clarity.
- Enhanced the filtering process to ensure only relevant modules are excluded based on the target modules set.
Member
|
@yeonjoon-jung01 thank you for your contribution but I am afraid I will have to ask you to close the PR as I will open a PR shortly fixing the issue on a deeper level. I hope you will understand and I am sorry about the situation. |
Member
Member
|
Closing the PR in favor of #11999. Thank you for your contributions, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in src/diffusers/utils/peft_utils.py when loading LoRA weights: if an excluded module name is a substring of a target module name, it unintentionally prevents the target module from being loaded.
A simple reproduction example:
This is a known issue, as discussed in:
load_lora_weightsbug in FLUX.1diffusers-0.35.0.dev0#11885exclude_moduleswon't consider the modules names intarget_modules#11874Although the PEFT library is preparing a fix (see huggingface/peft#2637 (comment)), it's uncertain when that change will be released as part of a stable version. In the meantime, this bug exists in the current main branch of Diffusers and needs to be addressed immediately.
The proposed fix modifies the logic in Diffusers to ensure that exclude_modules are not substring of any target module name, preventing incorrect exclusions. This change may be rolled back in the future once the PEFT-side fix is available and adopted, but until then, it ensures correct and stable behavior for users.