-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[modular]Update model card to include workflow #13195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yiyixuxu
wants to merge
3
commits into
main
Choose a base branch
from
update-model-card
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+150
−86
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,7 @@ def load_or_create_model_card( | |
| widget: list[dict] | None = None, | ||
| inference: bool | None = None, | ||
| is_modular: bool = False, | ||
| update_model_card: bool = False, | ||
| ) -> ModelCard: | ||
| """ | ||
| Loads or creates a model card. | ||
|
|
@@ -133,6 +134,9 @@ def load_or_create_model_card( | |
| `load_or_create_model_card` from a training script. | ||
| is_modular: (`bool`, optional): Boolean flag to denote if the model card is for a modular pipeline. | ||
| When True, uses model_description as-is without additional template formatting. | ||
| update_model_card: (`bool`, optional): When True, regenerates the model card content even if one | ||
| already exists on the remote repo. Existing card metadata (tags, license, etc.) is preserved. Only | ||
| supported for modular pipelines (i.e., `is_modular=True`). | ||
| """ | ||
| if not is_jinja_available(): | ||
| raise ValueError( | ||
|
|
@@ -141,9 +145,17 @@ def load_or_create_model_card( | |
| " To install it, please run `pip install Jinja2`." | ||
| ) | ||
|
|
||
| if update_model_card and not is_modular: | ||
| raise ValueError("`update_model_card=True` is only supported for modular pipelines (`is_modular=True`).") | ||
|
|
||
| try: | ||
| # Check if the model card is present on the remote repo | ||
| model_card = ModelCard.load(repo_id_or_path, token=token) | ||
| # For modular pipelines, regenerate card content when requested (preserve existing metadata) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes very cool approach! |
||
| if update_model_card and is_modular and model_description is not None: | ||
| existing_data = model_card.data | ||
| model_card = ModelCard(model_description) | ||
| model_card.data = existing_data | ||
| except (EntryNotFoundError, RepositoryNotFoundError): | ||
| # Otherwise create a model card from template | ||
| if from_training: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both?
Here, we already have:
Then having a collapsible block (essentially with the same info)
seems to be redundant to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, they look like this now https://huggingface.co/YiYiXu/modular-loader-t2i-20260227