Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter #1075

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix linter #1075

merged 2 commits into from
Dec 16, 2024

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Dec 14, 2024

No description provided.

@pcuenca
Copy link
Member Author

pcuenca commented Dec 14, 2024

The CI is not failing in the PRs (here or here), but it does on merge.

@pcuenca
Copy link
Member Author

pcuenca commented Dec 14, 2024

I guess origin/$PR_REF does not work for PRs coming from forks cc @coyotte508

@pcuenca pcuenca merged commit 5e30578 into main Dec 16, 2024
5 checks passed
@pcuenca pcuenca deleted the pcuenca-patch-1 branch December 16, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

@julien-c julien-c julien-c approved these changes

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcuenca @julien-c @coyotte508